Fix opaqueness violation in Task.Supervisor #14656
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
Jul 17, 2025
lib/elixir/lib/task.ex
Outdated
| # exported only to avoid dialyzer opaqueness check in internal Task modules | ||
| @doc false | ||
| @spec build_alias(pid()) :: Task.ref() | ||
| def build_alias(pid) do |
There was a problem hiding this comment.
Suggested change
| def build_alias(pid) do | |
| def __alias__(pid) do |
So it is not accidentally imported.
There was a problem hiding this comment.
Good call! Perhaps I could keep the defp build_alias too to avoid messing with the optimizations?
|
Is this flake? 🤔 |
Run
Yes, I have been chasing it for a while now. |
Thx for checking! I decided to still go with the private function, so that we keep the consistency with |
josevalim
approved these changes
Jul 17, 2025
sabiwara
added a commit
that referenced
this pull request
Jul 17, 2025
ggVGc
pushed a commit
to ggVGc/elixir-verbatim
that referenced
this pull request
Sep 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14655
But we need to check the optimization in
__recv_opt_info__isn't broken, I'm not sure how.To be backported.